Add min, max and length contraints to the GeospatialField by davidjamesstone · Pull Request #399 · DEFRA/forms-engine-plugin

davidjamesstone · 2026-05-15T12:27:14Z

Proposed change

Add min, max and exact length schema constraints to the GeospatialField.
Depends on DEFRA/forms-designer#1442

Jira ticket: https://eaflood.atlassian.net/browse/DF-1086

Type of change

Bug fix
New feature
Breaking change
Misc. (documentation, build updates, etc)

Checklist

You have executed this code locally and it performs as expected.
You have added tests to verify your code works.
You have added code comments and JSDoc, where appropriate.
There is no commented-out code.
You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
The tests are passing (npm run test).
The linting checks are passing (npm run lint).
The code has been formatted (npm run format).

jbarnsley10 · 2026-05-18T13:28:14Z

+
    expect(result.error).toBeUndefined()
-    expect(result.value).toEqual([])
+    expect(result.value).toBeUndefined()


Is this correct, or should it be an empty array still?

Yes that's correct now

I needed to change the behavior slightly because we introduced min/max and when used with optional, there's a bit of a question mark. I decided to make it work like this:

If the field is optional, you don't have to add anything

If the field is optional and has a min/max/length, you don't have to add anything but once you do, they have to also satisfy the min/max limits.

sonarqubecloud · 2026-05-18T13:40:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

davidjamesstone · 2026-05-18T13:51:41Z

Regarding the singular/plural in the error messages, we agreed to pick this up in a separate ticket. These messages come from joi and will need addressing in other components like File upload and Checkboxes.

Add min, max and length contraints to the GeospatialField

d5c86d3

davidjamesstone force-pushed the feature/DF-1084-feature-limits branch from 56dae24 to d5c86d3 Compare May 18, 2026 12:45